erase functions have bugs #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before calling them would either lead to an exception being thrown or a null pointer dereference. Signed-off-by: Eric Curtin <ecurtin@redhat.com>
Contributor
|
Thanks @ericcurtin ! We'll also need tiny tests to exercise that code in tests/test-syntax.cpp, I'll add some as follow up |
Contributor
|
Only realizing now these weren't plugged yet (pending in #17), was on the fence as to whether to merge as not used by any template, but probably core enough that it's worth merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before calling them would either lead to an exception being thrown or a null pointer dereference.